Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup github workflows add latest JDK #8652

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 68 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
cache: 'gradle'
native-image-job-reports: true
components: 'native-image'

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
Expand Down Expand Up @@ -372,7 +371,6 @@ jobs:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/master' || contains(github.event.pull_request.labels.*.name, 'jdkversions') || contains(github.event.pull_request.labels.*.name, 'renovate')


steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -403,6 +401,74 @@ jobs:
- name: Run Checks
run: ./gradlew test -Dtest.java.version=21

testopenjdklatest:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/master' || contains(github.event.pull_request.labels.*.name, 'jdkversions') || contains(github.event.pull_request.labels.*.name, 'renovate')

steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 11

- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 23

- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 17
Comment on lines +414 to +430
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 11
- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 23
- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 17
- name: Configure JDKs
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: |
11
17
23


- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4

- name: Run Checks
run: ./gradlew test -Dtest.java.version=23

testopenjdkearlyaccess:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/master' || contains(github.event.pull_request.labels.*.name, 'jdkversions') || contains(github.event.pull_request.labels.*.name, 'renovate')

steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 11

- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 24-ea

- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 17
Comment on lines +448 to +464
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 11
- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 24-ea
- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: 17
- name: Configure JDK
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: |
11
17
24-ea


- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4

- name: Run Checks
run: ./gradlew test -Dtest.java.version=24

testwindows:
runs-on: windows-latest
# TODO add master build after fixing all tests in CI
Expand Down Expand Up @@ -462,7 +528,6 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
cache: 'gradle'
native-image-job-reports: true
components: 'native-image'

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,12 @@ class LoggingEventListenerTest {
.assertLogMatch(Regex("""secureConnectStart"""))
.assertLogMatch(
Regex(
"""connectFailed: null \S+(?:SSLProtocolException|SSLHandshakeException|TlsFatalAlert): (?:Unexpected handshake message: client_hello|Handshake message sequence violation, 1|Read error|Handshake failed|unexpected_message\(10\)).*""",
"""connectFailed: null \S+(?:SSLProtocolException|SSLHandshakeException|TlsFatalAlert): .*(?:Unexpected handshake message: client_hello|Handshake message sequence violation, 1|Read error|Handshake failed|unexpected_message\(10\)).*""",
),
)
.assertLogMatch(
Regex(
"""callFailed: \S+(?:SSLProtocolException|SSLHandshakeException|TlsFatalAlert): (?:Unexpected handshake message: client_hello|Handshake message sequence violation, 1|Read error|Handshake failed|unexpected_message\(10\)).*""",
"""callFailed: \S+(?:SSLProtocolException|SSLHandshakeException|TlsFatalAlert): .*(?:Unexpected handshake message: client_hello|Handshake message sequence violation, 1|Read error|Handshake failed|unexpected_message\(10\)).*""",
),
)
.assertNoMoreLogs()
Expand Down
Loading