Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for IDBFS by:
FS.syncfs
can be called.Database
API to accept astring
in addition to aUint8Array
in its constructor, which setsthis.filename
accordingly. This is to allow for backwards compatibility. Previously, passing strings would throw.There's one major shortcoming with this PR which is that I have to remove
--closure 1
onEMFLAGS_OPTIMIZED
otherwise some methods onFS
are minified (mount
andsyncfs
are affected). I'm unsure why the closure compiler is doing this.To use IDBFS, users need to:
IDBFS support is preferable in some cases over
Database.export
as that function will close the database/clear prepared statements and make theDatabase
subsequently unusable.SQL.FS.syncfs
however will not close the database.Fixes #302 but for clarity: this is just writing files, so is database-level scoped, not table/row level scoped.