PR: Update setup.py to accommodate the Conda-forge package split (Installation)
#23141
Conversation
mrclary
force-pushed
the
spyder-base
branch
3 times, most recently
from
d195c4b to
690bc4b
Compare
There was a problem hiding this comment.
A couple of small suggestions, the rest looks good to me @mrclary.
mrclary
force-pushed
the
spyder-base
branch
5 times, most recently
from
c53167a to
538b26d
Compare
mrclary
force-pushed
the
spyder-base
branch
3 times, most recently
from
5953a10 to
f3e798f
Compare
| 'qtconsole>=5.6.1,<5.7.0', | ||
| ], | ||
| 'conda-forge': [ | ||
| 'qtconsole>=5.6.1,<5.7.0', |
There was a problem hiding this comment.
Shouldn't this be qtconsole-base instead of qtconsole, as you have it before?
Otherwise, qtconsole will bring pyqt5, won't it?
There was a problem hiding this comment.
So this is a bit nuanced.
When qtconsole-base is installed by conda, conda list shows qtconsole-base 5.6.1, but pip list shows qtconsole 5.6.1. If setup.py specifies qtconsole-base, pip --check fails with spyder 6.1.0a1.dev0 requires qtconsole-base, which is not installed.. See this pipline failure.
Specifying qtconsole in setup.py will only introduce pyqt5 if Spyder is built with SPYDER_QT_BINDING=conda-forge and the resulting package is installed using pip. I don't know how to install qtconsole-base and also have pip see it as such.
There was a problem hiding this comment.
Understood, thanks for the clarification @mrclary! Let's leave things like this then.
…. Clarified and streamlined.
Co-authored-by: Carlos Cordoba <[email protected]>
The conda build test environment uses the requirements in meta.yaml and pip check uses the METADATA in the egg-info populated by this setup.py. However, qtconsole-base shows up in the environment as qtconsole, so pip check doesn't think qtconsole-base is installed.
ccordoba12
changed the title
setup.py to accommodate the Conda-forge package split
ccordoba12
changed the title
setup.py to accommodate the Conda-forge package splitsetup.py to accommodate the Conda-forge package split (Installation)
|
@meeseeksdev please backport to 6.x |
…e Conda-forge package split (Installation)
…e the Conda-forge package split (Installation)) (#23270)
Description of Changes
conda-forge/spyder-feedstock#203 splits Spyder's conda package into two packages. This PR updates
setup.pyto accommodate this change when building Spyder conda packages for PRs.This should only affect the installer workflow, so can be merged any time.