PR: Update minimal required version of pylint to >=2.5.0,<3.1
#21470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
pylint 3pylint to >=2.5.0,<3.1
|
Note: If we decide to include this on 5.5.0, this will need to be rebased into the |
|
Agreed. @bnavigator, to include this in our next release, please run the following commands locally: |
|
Note: This requires to merge first PR python-lsp/python-lsp-server#475 and then sync our subrepo here so that our tests actually run with Pylint 3 and catch any possible regression. |
|
@bnavigator, I'm going to take care of finishing this one so we can be sure to include it in 5.5. |
subrepo: subdir: "external-deps/python-lsp-server" merged: "5f53f8e7ec" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "5f53f8e7ec" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
This comment was marked as off-topic.
This comment was marked as off-topic.
ccordoba12
reviewed
Oct 31, 2023
There was a problem hiding this comment.
@dalthviz, these are a couple of comments for you before doing the release.
| @@ -26,6 +26,9 @@ if [ "$USE_CONDA" = "true" ]; then | |||
| # Remove pylsp before installing its subrepo below | |||
| micromamba remove --force python-lsp-server python-lsp-server-base -y | |||
|
|
|||
| # Install Pylint 3 to run our tests with it | |||
| micromamba install pylint=3 -q -y | |||
There was a problem hiding this comment.
Remove these lines when PyLSP 1.9 is released.
Comment on lines
+48
to
+49
| # Install Pylint 3 to run our tests with it | ||
| pip install -U pylint |
ccordoba12
approved these changes
Oct 31, 2023
ccordoba12
added a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Pylint 3 removed long deprecated
find_pylintrc()which was only a wrapper tofind_default_config_files().pylint-dev/pylint#9105
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
bnavigator