Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate TryFrom<Type> for all suites #597

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

ivan770
Copy link
Contributor

@ivan770 ivan770 commented Aug 14, 2024

Closes #596

@timothee-haudebourg
Copy link
Contributor

Hi, I know it's annoying be I would prefer to have all the implementations related to a suite located in its module. It makes things easier to locate.

@ivan770
Copy link
Contributor Author

ivan770 commented Aug 23, 2024

Hi, I know it's annoying be I would prefer to have all the implementations related to a suite located in its module. It makes things easier to locate.

Would the same macro-based solution invoked in individual modules suffice?

@timothee-haudebourg
Copy link
Contributor

Would the same macro-based solution invoked in individual modules suffice?

Yes, that's alright, thanks!

@timothee-haudebourg
Copy link
Contributor

I see you've made some changes. Please request a review or ping me when you think its ready.

@ivan770
Copy link
Contributor Author

ivan770 commented Aug 23, 2024

I see you've made some changes. Please request a review or ping me when you think its ready.

It's ready for review.

@timothee-haudebourg timothee-haudebourg self-assigned this Aug 23, 2024
@ivan770
Copy link
Contributor Author

ivan770 commented Aug 23, 2024

There were some CI warnings related to unused macro and unused imports when no suites are enabled.

Considering that some items near the try_from_type macro already have #[allow(unused_imports)] attached to them, I decided to stick with the same approach.

Copy link
Contributor

@timothee-haudebourg timothee-haudebourg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@timothee-haudebourg timothee-haudebourg merged commit 5d42e14 into spruceid:main Aug 23, 2024
4 checks passed
@ivan770 ivan770 deleted the impl-try-from-type branch August 23, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual suites are missing TryFrom<ssi_data_integrity_core::Type>
2 participants