-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate TryFrom<Type> for all suites #597
Generate TryFrom<Type> for all suites #597
Conversation
Hi, I know it's annoying be I would prefer to have all the implementations related to a suite located in its module. It makes things easier to locate. |
Would the same macro-based solution invoked in individual modules suffice? |
Yes, that's alright, thanks! |
3ed1b38
to
992a481
Compare
I see you've made some changes. Please request a review or ping me when you think its ready. |
It's ready for review. |
There were some CI warnings related to unused macro and unused imports when no suites are enabled. Considering that some items near the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks a lot!
Closes #596