Add initial storage manager #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosirian
requested review from
jszersze,
CharlesShuller,
todd-spruceid,
JacobHealy-Spruce and
bryceteinck
theosirian
force-pushed
the
feat/camv-531-sprucekit-sdk-storage-manager-kotlin
branch
from
4dbeb00 to
a61307a
Compare
cobward
requested changes
Aug 1, 2024
| val dataStore: DataStore<Preferences> = store(context, "default") | ||
|
|
||
| companion object { | ||
| private const val FILENAME_PREFIX = "datastore_" |
There was a problem hiding this comment.
For the prefix and the encryption key, could we use something sprucekit specific to avoid name clashes when someone imports this library into their application? Maybe:
sprucekit/datastore/directories to store the files in?sprucekit-datastorefor the encryption key?
There was a problem hiding this comment.
@todd-spruceid WDYT doing something similar in mobile-sdk-swift for consistency?
There was a problem hiding this comment.
I'd be inclined to suggest just sprucekit for the directory, but regardless, it probably makes sense to do the same in -swift, mostly for ease of maintenance.
cobward
approved these changes
Aug 5, 2024
todd-spruceid
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
There's a list() being added to the protocol (see spruceid/mobile-sdk-rs#24) which will affect this code later.
Signed-off-by: Tiago Nascimento <[email protected]>
Signed-off-by: Tiago Nascimento <[email protected]>
rschulman
force-pushed
the
feat/camv-531-sprucekit-sdk-storage-manager-kotlin
branch
from
e591d89 to
c3a10d5
Compare
|
Rebased onto main and fixed one reference to |
rschulman
requested review from
sbihel,
cobward and
todd-spruceid
and removed request for
jszersze
todd-spruceid
approved these changes
Sep 16, 2024
rschulman
deleted the
feat/camv-531-sprucekit-sdk-storage-manager-kotlin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.