Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: 모달 버튼 컴포넌트 variant 속성 추가, 누락된 dependency 추가 #210

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Hotfix: 모달 버튼 컴포넌트 variant 속성 추가, 누락된 dependency 추가 #210

merged 2 commits into from
Mar 28, 2024

Conversation

designsoo
Copy link
Contributor

관련 문서

  • issue: #
  • close #

유형

  • 기능 구현
  • UI 구현
  • 리팩토링
  • 버그 해결
  • 문서 업데이트
  • 기타( )

작업 내용

  • 상세페이지의 post type이 오프라인일 경우 모달 버튼이 보이지 않아 variant=success 속성을 추가하였습니다.
  • 누락된 isNoSchedule를 dependency array에 추가하였습니다.

스크린샷

button

@designsoo designsoo added the 리팩토링 리팩토링 label Mar 28, 2024
CheeseB
CheeseB approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@CheeseB CheeseB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@designsoo designsoo added the 🚨ASAP As Soon As Possible label Mar 28, 2024
@designsoo designsoo merged commit a90cc43 into dev Mar 28, 2024
1 check passed
@designsoo designsoo deleted the hotfix/postDetail/heesoo branch March 28, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccwnc ccwnc ccwnc approved these changes

@grapefruit13 grapefruit13 grapefruit13 approved these changes

@CheeseB CheeseB CheeseB approved these changes

Assignees

@designsoo designsoo

Labels
리팩토링 리팩토링 🚨ASAP As Soon As Possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@designsoo @CheeseB @grapefruit13 @ccwnc