Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 마이페이지 - 등록한 게시글 탭 수정사항 반영 #185

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Fix: 마이페이지 - 등록한 게시글 탭 수정사항 반영 #185

merged 4 commits into from
Mar 23, 2024

Conversation

CheeseB
Copy link
Contributor

@CheeseB CheeseB commented Mar 23, 2024 •
edited
Loading

유형

  • 기능 구현
  • UI 구현
  • 리팩토링
  • 버그 해결
  • 문서 업데이트
  • 기타( )

작업 내용

  • 마이페이지의 등록한 게시글 탭 버그 수정, 스타일 수정, 리팩터링

설명

📌 기능

  • 카드 컴포넌트의 Link 태그 때문에 케밥메뉴를 클릭했을 때 링크이동이 되는 오류 수정 -> event.preventDefault()
  • Sort Opion 을 상수에서 불러와서 사용

📌 UI

  • 정렬 드롭다운을 디바이스 타입에 따라 두개 만들었던 것을 하나로 합치고, position: absolute 로 위치만 이동시킴
  • 케밥버튼이 케밥메뉴를 뚫고 나오는 오류 수정 -> 케밥메뉴의 z-index 제거

@CheeseB CheeseB added 버그 해결 버그 해결 리팩토링 리팩토링 labels Mar 23, 2024
@CheeseB CheeseB added the 🎉 수정 완료 수정 완료 label Mar 23, 2024
grapefruit13
grapefruit13 approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@grapefruit13 grapefruit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

designsoo
designsoo approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@designsoo designsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ccwnc
ccwnc approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@ccwnc ccwnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CheeseB CheeseB merged commit 6892e1f into dev Mar 23, 2024
1 check passed
@CheeseB CheeseB deleted the feat/mypage/seongyeon branch March 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccwnc ccwnc ccwnc approved these changes

@grapefruit13 grapefruit13 grapefruit13 approved these changes

@designsoo designsoo designsoo approved these changes

Assignees

@CheeseB CheeseB

Labels
리팩토링 리팩토링 버그 해결 버그 해결 🎉 수정 완료 수정 완료
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CheeseB @designsoo @grapefruit13 @ccwnc