Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paths with params condition option #2761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jelicho
Copy link

@Jelicho Jelicho commented Oct 12, 2024

@bnasslahsen

Hello, I propose a new option to expose params condition in the path, allowing the value to be differently exposed in the path as well.

I understand the comment you provided regarding this issue (#2691 )and respect the direction of using the path and HttpMethod as identifiers for API uniqueness.

While it's true that params condition alone may not guarantee uniqueness, it plays a role in refining the request, making it a valid option to offer. Additionally, the Spring Framework's RequestMappingHandler supports API mapping separation based on params condition, and I believe there are cases where others have similar requirements.

Therefore, I would like to gradually improve this feature by providing it as an option that users can use if needed.

Of course, this is just another direction I'm suggesting.

Thank you.

resolved : #2691

@bnasslahsen
Copy link
Contributor

@Jelicho,

I would be happy to merge it, but you need to add the unit tests and the webflux implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not distinction between different parameter conditions on the same path in swagger json.
2 participants