Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new parameter failOnError, which can be set to fail builds #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

timbuethe
Copy link

This adds a new parameter called failOnError which should makes builds fail, instead of just logging an error, if the file download fails (return code != 200).

@timbuethe
Copy link
Author

Hi,
is there any chance this gets reviewed and hopefully merged?
Is there anything else you need from my side to move forward?

cc: @DennisHalmstad @bnasslahsen

@amitojduggal
Copy link

@bnasslahsen possible to review this MR? Its a very useful feature to have.

@bnasslahsen
Copy link
Contributor

@timbuethe,

I will have a look in the week-end!

@MrSebastian
Copy link

Hi @timbuethe,

i am also interested in your solution for #59. Can u add your handler at the catch-Block of exceptions too? It will help in situations like connection refused.

@MrSebastian
Copy link

I noticed that my application, that i started in pre-integration-test phase, did not stopped after the exception. I suggest to check, that the output exists, in the verify phase.

@timbuethe
Copy link
Author

@MrSebastian I also added it to the catch clause, let men know what you think.

@MrSebastian
Copy link

@timbuethe thx, yes that would work and throw an exception when requested service is unreachable.

But as mentioned in my comment before, it would be useful to have a separate verify goal. But i guess this is something the maintainer should decide. I hope it is ok to discuss things like that in this PR (this is my first foreign github project I participate with).

@timbuethe
Copy link
Author

@MrSebastian I agree, but let's see what @bnasslahsen has to say.

@S2Philipp
Copy link

It would also be nice to know why it failed to generate the file.
The 401 does not tell me anything actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants