-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new parameter failOnError
, which can be set to fail builds
#60
base: master
Are you sure you want to change the base?
Conversation
…rrors occur (e.g. download fails)
Hi, |
@bnasslahsen possible to review this MR? Its a very useful feature to have. |
I will have a look in the week-end! |
Hi @timbuethe, i am also interested in your solution for #59. Can u add your handler at the catch-Block of exceptions too? It will help in situations like |
I noticed that my application, that i started in |
@MrSebastian I also added it to the catch clause, let men know what you think. |
@timbuethe thx, yes that would work and throw an exception when requested service is unreachable. But as mentioned in my comment before, it would be useful to have a separate verify goal. But i guess this is something the maintainer should decide. I hope it is ok to discuss things like that in this PR (this is my first foreign github project I participate with). |
@MrSebastian I agree, but let's see what @bnasslahsen has to say. |
It would also be nice to know why it failed to generate the file. |
This adds a new parameter called
failOnError
which should makes builds fail, instead of just logging an error, if the file download fails (return code != 200).