-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeepSeek model client #702
base: main
Are you sure you want to change the base?
Add DeepSeek model client #702
Conversation
hi, I agree with your point. I have two thoughts. |
41505f6
to
c34da10
Compare
this PR has completed the refactoring, has been squashed and force pushed again. |
In my experience at the model level, I agree that once you get into the details, "api compatability" is surface level. On the other hand, there is indeed a model "zoo" that can add to maintenance and carries risk of them disappearing. I suspect that over time, once the market decides on winners and losers in the marketplace, there will be consolidation and some models in spring ai will go away. As a concrete example of that, Google's PAaM API is deprecated so we will be removing it (I'll create an issue). |
I'm still not sure what to do here. Other opinions? @mxsl-gr have you tried to use Spring AI's OpenAI support to talk with this model? |
hi @markpollack , i have been busy with other work recently. we are using a customized version built on my local branch, which merges this branch with other strange features. for example, we have a multi-level model that can handle tasks at different levels to improve speed or reduce costs, as well as a client pool and polling mechanisms to enhance throughput and redundancy. |
Thanks for the update. I did take a look at the github project, it doesn't seem active - https://github.com/deepseek-ai/DeepSeek-V2/graphs/contributors what is your opinion. Does function calling with OpenAI 'compatability' work. In practice, for chat models, I haven't seen much use of 'n' in the wild, say as compared to image models. |
oops, didn't mean to close. |
Also, llama3 has a similar commit history - minimal - I guess all the work is up front! https://github.com/meta-llama/llama3/graphs/contributors |
Hi, everyone! Do you have any plans for when the branch will be merged into the main branch? |
hi, for some reason, this PR hasn’t been merged yet. |
5bdf750
to
26e872a
Compare
Signed-off-by: GR <[email protected]>
26e872a
to
4b971e3
Compare
hi, @markpollack this PR has completed the refactoring, implemented beta features like the Function Call feature was added at this commit, but is not very stable, because the current version (V2.5 ~ V3) of DeepSeek's modal Function Call is unstable, the tests related to the function call have been temporarily disabled. All other tests have passed. References: |
Hi, this PR is add
DeepSeek
model client and has passed unit testing.I can provide my api_key if needed for testing
the PR content:
For some reasons, products from OpenAI and others can't be directly used in Chinese Mainland.
DeepSeek
is a strong, economical, and efficient Mixture of Experts (MoE) language model, with an API pricing of $0.14/$0.28 per 1 million tokens.the link: DeepSeek
If they can supported, it will further aid spring-ai to promotion in Chinese Mainland.
If necessary, I can take care of subsequent maintenance since I'm currently using them.
The
Moonshot
PR is #596The
ZhiPuAI
PR is #623The
MiniMax
PR is #628