Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add slf4j logging #2154

Closed

Conversation

ilayaperumalg
Copy link
Member

@ilayaperumalg ilayaperumalg commented Feb 1, 2025

  • This PR reverts the changes to update Apache Commons Logging and re-add the previously used slf4j logging

 - This PR reverts the changes to update Apache Commons Logging and re-add the previously used slf4j logging
@@ -59,6 +59,11 @@
<artifactId>spring-context-support</artifactId>
</dependency>

Copy link
Member

@markpollack markpollack Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all we need is

		<dependency>
			<groupId>org.slf4j</groupId>
			<artifactId>slf4j-api</artifactId>
			<version>${slf4j.version}</version>  <!-- should be removed and managed by spring-boot-dependencies-->
		</dependency>

@markpollack
Copy link
Member

made the change to use slf4j directly. Need to look, I think there are some version numbers in some of the slf4j deps, not managed via boot.

merged in 2932769

@markpollack markpollack closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants