Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the priority of the configs #303

Open
wants to merge 1 commit into
base: 3.1.x
Choose a base branch
from

Conversation

woshikid
Copy link

Close #302
config with profiles should have higher priority than others.

@woshikid
Copy link
Author

@ryanjbaxter this PR does the same thing as spring-cloud/spring-cloud-config#2207
spring-cloud-zookeeper also has the same issue as spring-cloud-config JDBC backend that we discussed yesterday.

@spencergibb
Copy link
Member

We can't do this as easily as config server since. While config server jdbc needed to match git, this has always functioned this way and may break users. It needs to be behind a flag and users must opt in. The default can be changed in 4.0.x

Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments

@woshikid
Copy link
Author

I think it's a bug. the zookeeper config didn't use the same config order in import and bootstrap mode.

Copy link
Contributor

@ryanjbaxter ryanjbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need documentation for the property

@woshikid
Copy link
Author

Documentation added.

@woshikid
Copy link
Author

@spencergibb a new flag is introduced as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants