Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support main port not being set when using SSL. #299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support main port not being set when using SSL. #299

wants to merge 1 commit into from

Conversation

guillaume-alvarez
Copy link

When using HTTPS/SSL the 'port' may not be set from property spring.cloud.zookeeper.discovery.instance-port. In that case avoid throwing an exception and take the port at runtime.

@guillaume-alvarez
Support main port not being set when using SSL.
a1c264f 
When using HTTPS/SSL the 'port' may not be set from property `spring.cloud.zookeeper.discovery.instance-port`. In that case avoid throwing an exception and take the port at runtime.
@guillaume-alvarez
Copy link
Author

CircleCI outputs this error:

#!/bin/sh -eo pipefail
# No configuration was found in your project. Please refer to https://circleci.com/docs/2.0/ to get started with your configuration.
# 
# -------
# Warning: This configuration was auto-generated to show you the message above.
# Don't rerun this job. Rerunning will have no effect.
false

@spencergibb
Copy link
Member

We're migrating to GitHub actions for prs, just authorized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting-for-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaume-alvarez @spencergibb @spring-cloud-issues