Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Headers Problem #2983

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

omercelikceng
Copy link
Contributor

Hello,

While working on a development related to Spring Cloud Stream, I noticed a situation that is also relevant to Spring Cloud Function.

To explain the issue clearly, we will first examine a method from Spring Cloud Function. The following method exhibits different behaviors. In some cases, it generates the output message using the input header, while in other cases, it does not consider the input header at all. This results in some variations in the code.
In other words, the code below can sometimes directly set the headers provided in the input to the output header. Sometimes, it creates the output headers without using the input headers.

Screenshot 2024-08-01 233525

Now, let's examine the method affected by the above code. I have written some tests, and based on the results, the target-protocol header is sometimes set and sometimes not. Therefore, I have made the relevant development.

However, I still have some questions that I do not fully understand. I would greatly appreciate your help. Is the target-protocol header a value that should be set for every message? If so, there are many places that we need to correct. Could you please provide me with information on this matter?

I am a bit confused, so I wanted to ask you before continuing with the development. Thank you.

}
}

@Test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the development I made is not implemented, only this test fails. The other tests complete successfully.

@olegz olegz merged commit 6aa9062 into spring-cloud:main Aug 8, 2024
1 check passed
@omercelikceng
Copy link
Contributor Author

omercelikceng commented Aug 8, 2024

@olegz, hello. Thank you very much for your interest. However, there are other situations where these headers are not set. If this target_protocol needs to be set in all cases, I will need to make further developments accordingly. Should I open another pull request to explain this better? Could you inform me about this?

@olegz
Copy link
Contributor

olegz commented Aug 8, 2024

Please do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants