Add @EnableTestBinder annotation #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobychacko
requested changes
May 9, 2024
| import java.lang.annotation.Target; | ||
|
|
||
| import org.springframework.context.annotation.Import; | ||
|
|
There was a problem hiding this comment.
Could you add some class level javadoc to this?
| @@ -518,7 +517,7 @@ void withMessageHeadersInputParameter() { | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Need copyright updates, author tag.
| @@ -591,13 +590,13 @@ private BindingServiceProperties createBindingServiceProperties( | |||
| return bindingServiceProperties; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Need copyright updates, author tag.
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Import; | ||
| import org.springframework.validation.annotation.Validated; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; |
There was a problem hiding this comment.
Need copyright updates, author tag.
| import org.springframework.context.ApplicationContext; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Import; | ||
| import org.springframework.retry.support.RetryTemplate; | ||
|
|
There was a problem hiding this comment.
Need copyright updates, author tag.
|
@kutmk Could you also add some documentation in the reference docs for this? |
|
@sobychacko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EnableTestBinderannotation to importTestChannelBinderConfigurationfor enabling TestBinder. This was decided in issue TestChannelBinder is exposed without including TestChannelBinderConfiguration #2931.@Import(TestChannelBinderConfiguration.class)with@EnableTestBinderin the tests.