GH-2662: Kafka binder DLQ root cause message #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Becasue NestedRuntimeException from Spring Framework core 6.x removed the getMessage method that included the detailMessage with cause in it, the Kafka binder DLQ records no longer include the cause message. Fix this issue by including the cause in the exception message. See this comment for more details: - spring-cloud#2662 (comment) This fix is based on the following Spring Kafka commit. - spring-projects/spring-kafka@6f58505 Resolves spring-cloud#2662
garyrussell
reviewed
Sep 20, 2023
|
@garyrussell What was the failure? |
|
A bunch of test failures; click on details. in the "All checks have failed". |
|
Ah, I think you can ignore those for the time being. Jenkins main CI is all good. This is a new ci-pr we added last week that needs to be cleaned up with a few things. |
garyrussell
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment for more details:
Resolves #2662