feat: allow multipart parts with content types #1929
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates to version 4.0.0-SNAPSHOT Updates to Java 17, framework 6, boot 3 and Jakarta EE Missing support for versions of rest assured, activemq-pool & jersey-client * Additional jdk17, spring cloud 2021, boot 3 upgrades * Fixed invalid version Co-authored-by: Marcin Grzejszczak <[email protected]> Co-authored-by: Marcin Grzejszczak <[email protected]>
Bumps xercesImpl from 2.12.0 to 2.12.2. --- updated-dependencies: - dependency-name: xerces:xercesImpl dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1755) * docs: Explain how to have multiple contracts in Groovy * Update _project-features-contract.adoc Co-authored-by: Marcin Grzejszczak <[email protected]>
| @@ -75,51 +64,10 @@ public static DslProperty asDslProperty(Object o) { | |||
| return new DslProperty(o); | |||
| } | |||
|
|
|||
| public DslProperty getName() { | |||
There was a problem hiding this comment.
I don't see these methods in the new parent class. If we don't leave them then we will have a breaking change (which we should avoid)
| @@ -94,29 +94,6 @@ protected static Pattern anyOf(String... values) { | |||
| .collect(Collectors.joining("|"))); | |||
| } | |||
|
|
|||
| public static String multipartParam(Object name, Object value) { | |||
There was a problem hiding this comment.
That's a breaking change
| @@ -716,26 +716,28 @@ then: | |||
|
|
|||
| assertThat(multipartData["file1"]).isInstanceOf(NamedProperty::class.java) | |||
| namedProperty = multipartData["file1"] as NamedProperty | |||
| assertThat(((namedProperty.name as DslProperty<Any>).clientValue as RegexProperty).pattern()).isEqualTo("[\\S\\s]+") | |||
|
Also since this is a new feature I think we should add it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP implementation for commentary of an alternative approach for
multipart/form-datasupport based off of the back of #1888 backed by WireMock's multipart support vs generating a regex against the request parts.Looking to pick this back up and progress if there is interest with some guidance.
DSL wise aim would be to provide something closer to the
multipart/form-dataspec to give a bit more freedom than currently possible, such as the following for a scenario of sending a correctly structured JSON metadata part and a file part in the request.