Merge pull request #420 from ritiek/fix-split-http-url

Trim '?<key>' when extracting ID from HTTP URLs
spotipy-dev · Jan 13, 2020 · 9c5b9c0 · 9c5b9c0
2 parents 4ec3207 + e6829a1
commit 9c5b9c0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+ - Fixed inconsistent behaviour with some API methods when
+   a full HTTP URL is passed.
+
 ### Changed
  - Fixed invalid calls to logging warn method
  - `mock` no longer needed for install. Only used in `tox`.

diff --git a/spotipy/client.py b/spotipy/client.py
@@ -1128,7 +1128,7 @@ def _get_id(self, type, id):
             if type != itype:
                 self._warn('expected id of type %s but found type %s %s' %
                            (type, itype, id))
-            return fields[-1]
+            return fields[-1].split('?')[0]
         return id
 
     def _get_uri(self, type, id):