Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for flaky GLIBC check on CI build #77

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

miclegr
Copy link
Contributor

@miclegr miclegr commented Jul 29, 2024

Description

In the Combine JAR step of the CI build we check for shared libraries to require GLIBC<=2.27. We do that by dumping objects from shared libraries, grepping for GLIBC, removing unrelated string parts and sorting. But in this way we are catching also GLIBCXX entries, so ultimately the check depends on whether last matched object in the library is a GLIBC or GLIBCXX entry.

Also the test currently is failing if the maximum GLIBC/GLIBCXX required version by the library is strickly less than the maximum we allow.

Changes Made

  • Improve check in the Combine JAR CI step.

Testing

Checklist

  • My code follows the code style of this project.
  • I have added and/or updated appropriate documentation (if applicable).
  • All new and existing tests pass locally with these changes.
  • I have run static code analysis (if available) and resolved any issues.
  • I have considered backward compatibility (if applicable).
  • I have confirmed that this PR does not introduce any security vulnerabilities.

Additional Comments

@miclegr miclegr marked this pull request as ready for review July 29, 2024 08:44
@miclegr miclegr changed the title Fix for flacky GLIBC check on CI build Fix for flaky GLIBC check on CI build Jul 29, 2024
Copy link
Member

@psobot psobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks @miclegr!

@miclegr miclegr merged commit 984854b into spotify:main Jul 29, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants