Update default Dataflow add-open opts for Java 17+ #5537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairemcginty
commented
Dec 19, 2024
|
|
||
| sys.props("java.version") match { | ||
| case javaVersionRe(version) | ||
| if version.toInt >= 17 && dataflowPipelineOpts.getJdkAddOpenModules == null => |
There was a problem hiding this comment.
I suppose this is also a bugfix PR for Java 21 users 😬
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5537 +/- ##
==========================================
+ Coverage 61.43% 61.44% +0.01%
==========================================
Files 312 312
Lines 11106 11105 -1
Branches 750 776 +26
==========================================
+ Hits 6823 6824 +1
+ Misses 4283 4281 -2 ☔ View full report in Codecov by Sentry. |
RustedBones
approved these changes
Dec 20, 2024
|
We should add it there too for the tests |
RustedBones
reviewed
Dec 20, 2024
| dataflowPipelineOpts.setJdkAddOpenModules( | ||
| List("java.base/java.util=ALL-UNNAMED", "java.base/java.lang.invoke=ALL-UNNAMED").asJava | ||
| ) | ||
| val javaVersionRe = "^(\\d+)\\..*".r |
There was a problem hiding this comment.
This regex would give 1 for java 8 (version is set as 1.8....).
Let's use the same def as for the build
System.getProperty("java.version").stripPrefix("1.").takeWhile(_.isDigit).toInt
RustedBones
force-pushed
the
17-default-opts
branch
from
87fd804 to
2b14afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match all the add-opens required by Kryo
tested in Dataflow