Stable TableRow converted from BQ types #5536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coder[TableRow] is destructive (it is a dummy JSON serializer), we should make sure that the TableRow object converted from a BQ model is stable after serialization. We currently have an issue with - long that are serialized as string to avoid overflow - float that are read back as double - json that is read as nested TableRow
RustedBones
commented
Dec 19, 2024
| val provider: OverrideTypeProvider = | ||
| OverrideTypeProviderFinder.getProvider | ||
| val s = q"$tree.toString" |
There was a problem hiding this comment.
we were forcing toString before converting back to desired type
RustedBones
force-pushed
the
bq-typed-stable-table-row
branch
from
fdd4fbb to
d8d30c8
Compare
RustedBones
commented
Dec 19, 2024
Comment on lines
+56
to
+58
| // f is a field from TableRow. | ||
| // Jackson ObjectMapper will fail with such key | ||
| key <- Gen.alphaStr.retryUntil(_ != "f") |
There was a problem hiding this comment.
I'm wondering what happens if a BQ table has a field named f. It's probable that we can't use the TableRow API
RustedBones
force-pushed
the
bq-typed-stable-table-row
branch
from
d8d30c8 to
d76d226
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5536 +/- ##
==========================================
+ Coverage 61.43% 61.45% +0.01%
==========================================
Files 312 312
Lines 11106 11106
Branches 750 748 -2
==========================================
+ Hits 6823 6825 +2
+ Misses 4283 4281 -2 ☔ View full report in Codecov by Sentry. |
RustedBones
commented
Dec 20, 2024
There was a problem hiding this comment.
Ideally all the TableRow -> scala cast logic should be shared with TableRowOps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coder[TableRow] is destructive (it is a dummy JSON serializer), we should make sure that the TableRow object converted from a BQ model is stable after serialization.
We currently have an issue with
As side effect, I needed to avoid
toStringconversion when converting back a BQ typed model from aTableRow