Allow timeout for async DoFn #5534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
force-pushed
the
async-do-fn-timeout
branch
from
0c823d5 to
4b7ca53
Compare
Add unit testing Fit unit testing Make sure callback is completed Remove old branch relicate
RustedBones
force-pushed
the
async-do-fn-timeout
branch
from
4b7ca53 to
e84e3f2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5534 +/- ##
=======================================
Coverage 61.42% 61.43%
=======================================
Files 312 312
Lines 11104 11106 +2
Branches 757 750 -7
=======================================
+ Hits 6821 6823 +2
Misses 4283 4283 ☔ View full report in Codecov by Sentry. |
kellen
reviewed
Dec 11, 2024
| @@ -66,21 +68,26 @@ object BigtableDoFnTest { | |||
| val queue: ConcurrentLinkedQueue[Int] = new ConcurrentLinkedQueue[Int]() | |||
| } | |||
|
|
|||
| class TestBigtableDoFn extends BigtableDoFn[Int, String](null) { | |||
| class TestBigtableDoFn extends BigtableDoFn[Int, String](BigtableOptions.getDefaultOptions) { | |||
There was a problem hiding this comment.
Did you mean to have these BT changes here?
There was a problem hiding this comment.
Yes, in BT, the timeout is taken from the settings now, we can't pass null.
kellen
reviewed
Dec 11, 2024
|
+1 for a sane default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4040
Should we set a sane timeout default ?