-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to BigQuery read API v1 interface #5431
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5431 +/- ##
==========================================
+ Coverage 61.49% 61.51% +0.02%
==========================================
Files 312 312
Lines 11122 11120 -2
Branches 779 774 -5
==========================================
+ Hits 6840 6841 +1
+ Misses 4282 4279 -3 ☔ View full report in Codecov by Sentry. |
Thanks for the heads up! We completely missed this upgrade. |
To be clear, you didn't miss anything per se -- the official deprecation notice hasn't been sent out yet (although this is coming). However, Scio is one of the last read API use cases that I'm aware of which is in wide use and has yet to migrate to v1. If we can start the adoption process for the newer API surface now, the deprecation process will hopefully be less impactful for users. |
Hey folks, do you need anything from me here? If not, then is there a timeline for this to be merged? |
This change updates Scio's usage of the BigQuery storage read API to use the
v1
interface rather thanv1beta1
, which will eventually be deprecated. The two interfaces are very similar, to the extent that this change is mostly string substitution.I haven't yet been able to run end-to-end tests with this change. If there is no automated test coverage as part of the PR approval process, then I will figure out how to do so.