Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FixAvroCoder case application #5353

Merged
merged 1 commit into from
May 2, 2024
Merged

Refactor FixAvroCoder case application #5353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 28 additions & 25 deletions scalafix/rules/src/main/scala/fix/v0_14_0/FixAvroCoder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,28 +190,34 @@ class FixAvroCoder extends SemanticRule("FixAvroCoder") {
override def fix(implicit doc: SemanticDocument): Patch = {
val usesAvroCoders = doc.tree
.collect {
case q"$expr[..$tpesnel]" =>
// A method call with a type parameter requires an implicit Coder[T] for our type
findBoundedTypes(expr, tpesnel, CoderMatcher)
.exists(isAvroType)
case t @ q"..$mods val ..$patsnel: $tpeopt = $expr" =>
// Coder[T] is a variable type where T is an avro type
findMatchingValTypeParams(t, CoderMatcher)
.exists(isAvroType)
case q"$fn(..$args)" if JobTestBuilderMatcher.matches(fn) =>
args.headOption match {
case Some(q"$io[$tpe](..$args)") if isAvroType(tpe.symbol) => true
case _ => false
}
case q"$fn(..$args)" if ParallelizeMatcher.matches(fn) =>
args.headOption exists {
case expr if hasAvroTypeSignature(expr, true) => true
case q"$seqLike($elem)"
if seqLike.symbol.value.startsWith("scala/collection/") &&
(isAvroType(elem.symbol) || hasAvroTypeSignature(elem, false)) =>
true
case _ => false
}
// A method call with a type parameter requires an implicit Coder[T] for our type
case q"$expr[..$tpesnel]"
if findBoundedTypes(expr, tpesnel, CoderMatcher).exists(isAvroType) =>
true
// Coder[T] is a variable type where T is an avro type
case t @ q"..$mods val ..$patsnel: $tpeopt = $expr"
if findMatchingValTypeParams(t, CoderMatcher)
.exists(isAvroType) =>
true
case q"$fn(..$args)" if methodHasAvroCoderTypeBound(fn) => true
case q"..$mods def $ename(...$params): $tpe = $expr" if methodReturnsAvroSCollection(tpe) =>
true
case q"$fn(..$args)"
if JobTestBuilderMatcher.matches(fn) &&
(args.headOption match {
case Some(q"$io[$tpe](..$args)") if isAvroType(tpe.symbol) => true
case _ => false
}) =>
true
case q"$fn(..$args)" if ParallelizeMatcher.matches(fn) && (args.headOption exists {
case expr if hasAvroTypeSignature(expr, true) => true
case q"$seqLike($elem)"
if seqLike.symbol.value.startsWith("scala/collection/") &&
(isAvroType(elem.symbol) || hasAvroTypeSignature(elem, false)) =>
true
case _ => false
}) =>
true
case q"$expr(..$args)" if SmbReadMatchers.matches(expr) =>
args.tail.map(_.symbol.info.map(_.signature)).exists {
case Some(
Expand All @@ -225,9 +231,6 @@ class FixAvroCoder extends SemanticRule("FixAvroCoder") {
true
case _ => false
}
case q"$fn(..$args)" if methodHasAvroCoderTypeBound(fn) => true
case q"..$mods def $ename(...$params): $tpe = $expr" if methodReturnsAvroSCollection(tpe) =>
true
}
.foldLeft(false)(_ || _)
val avroValuePatch = if (usesAvroCoders) Patch.addGlobalImport(avroImport) else Patch.empty
Expand Down
Loading