Scalafix: Add Avro coder import for SpecificRecord JobTest IOs #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairemcginty
commented
Feb 12, 2024
| @@ -128,6 +133,19 @@ class FixAvroCoder extends SemanticRule("FixAvroCoder") { | |||
| // Coder[T] is a variable type where T is an avro type | |||
| findMatchingValTypeParams(t, CoderMatcher) | |||
| .exists(isAvroType) | |||
| case q"$jobTestBuilder(..$args)" if JobTestBuilderMatcher.matches(jobTestBuilder) => | |||
There was a problem hiding this comment.
I spent some time trying to make this generic, so that it would match any function with an implicit coder evidence T, by inspecting each function argument for one that matched type T, but it got pretty complex/edge-casey. Not sure it's worth it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
==========================================
- Coverage 62.64% 62.63% -0.01%
==========================================
Files 301 301
Lines 10849 10849
Branches 745 745
==========================================
- Hits 6796 6795 -1
- Misses 4053 4054 +1 ☔ View full report in Codecov by Sentry. |
RustedBones
approved these changes
Feb 13, 2024
Comment on lines
+161
to
+162
| case importer"com.spotify.scio.avro.{..$imps}" => | ||
| imps.map(i => Patch.removeImportee(i) + Patch.addGlobalImport(avroImport)).asPatch |
There was a problem hiding this comment.
This may have an impact on import alias, but I think this is still worth it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.