Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix #5067) Drop Java 8 Targeting #5203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(fix #5067) Drop Java 8 Targeting #5203

wants to merge 2 commits into from

Conversation

clairemcginty
Copy link
Contributor

@clairemcginty clairemcginty commented Jan 24, 2024

Fix #5067

Testing: Checked javac/scalacOptions

% sbt "show javacOptions"
...
[info] 	List(-deprecation, -encoding, UTF-8, -feature, -unchecked, -Wextra-implicit, -Wnumeric-widen, -Wunused, -Xlint:_,-implicit-recursion,-recurse-with-default,-unused,-byname-implicit, -Wconf:cat=scala3-migration:s, -Ybackend-parallelism, 10, -language:_, -release, 11, -Ydelambdafy:inline, -Wconf:cat=deprecation&origin=scala\..*&since>2.12.99:s,cat=unused-imports&origin=scala\.collection\.compat\..*:s,cat=unused-imports&origin=kantan\.codecs\.compat\..*:s,cat=unused-imports&origin=com\.spotify\.scio\.repl\.compat\..*:s,cat=unused:e, -Wmacros:after, -Ymacro-annotations, -Xmacro-settings:show-coder-fallback=true)


% sbt "show scalacOptions"
[info] javacOptions
...
[info] 	List(-encoding, utf8, --release, 11)

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.56%. Comparing base (91d4d80) to head (ff48046).
Report is 116 commits behind head on main.

❗ Current head ff48046 differs from pull request most recent head d2fca47. Consider uploading reports for the commit d2fca47 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5203   +/-   ##
=======================================
  Coverage   62.56%   62.56%           
=======================================
  Files         301      301           
  Lines       10807    10807           
  Branches      764      764           
=======================================
  Hits         6761     6761           
  Misses       4046     4046           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RustedBones
Copy link
Contributor

Let's also update the README

scio/README.md

Line 36 in 80c6d3c

Download and install the [Java Development Kit (JDK)](https://adoptopenjdk.net/index.html) version 8.

@RustedBones RustedBones added this to the 0.15.0 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop java 8 support
2 participants