Update default Dataflow add-open opts for Java 17+

spotify · Dec 19, 2024 · a1fce4a · a1fce4a
1 parent 532e915
commit a1fce4a
Showing 1 changed file with 15 additions and 9 deletions.
diff --git a/scio-core/src/main/scala/com/spotify/scio/runners/dataflow/DataflowContext.scala b/scio-core/src/main/scala/com/spotify/scio/runners/dataflow/DataflowContext.scala
@@ -41,16 +41,22 @@ case object DataflowContext extends RunnerContext {
       .filesToStage(options, classLoader, localArtifacts, artifacts)
       .asJavaCollection
 
-    // Required for Kryo w/ Java 17
+    // Required for Kryo w/ Java 17+
     lazy val dataflowPipelineOpts = options.as(classOf[DataflowPipelineOptions])
-    if (
-      sys
-        .props("java.version")
-        .startsWith("17.") && dataflowPipelineOpts.getJdkAddOpenModules == null
-    ) {
-      dataflowPipelineOpts.setJdkAddOpenModules(
-        List("java.base/java.util=ALL-UNNAMED", "java.base/java.lang.invoke=ALL-UNNAMED").asJava
-      )
+    val javaVersionRe = "^(\\d+)\\..*".r
+
+    sys.props("java.version") match {
+      case javaVersionRe(version)
+          if version.toInt >= 17 && dataflowPipelineOpts.getJdkAddOpenModules == null =>
+        dataflowPipelineOpts.setJdkAddOpenModules(
+          List(
+            "java.base/java.util=ALL-UNNAMED",
+            "java.base/java.lang.invoke=ALL-UNNAMED",
+            "java.base/java.lang=ALL-UNNAMED",
+            "java.base/java.nio=ALL-UNNAMED"
+          ).asJava
+        )
+      case _ => // Only add opts for Java 17+
     }
 
     dataflowOptions.setFilesToStage(new java.util.ArrayList(filesToStage))