WeightedSample singleton ordering

spotify · Nov 4, 2024 · 34378a8 · 34378a8
1 parent 910a776
commit 34378a8
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/scio-core/src/main/scala/com/spotify/scio/values/SampleSCollectionFunctions.scala b/scio-core/src/main/scala/com/spotify/scio/values/SampleSCollectionFunctions.scala
@@ -30,8 +30,13 @@ object SampleSCollectionFunctions {
 
   final private case class WeightedSample[T](id: Long, value: T, weight: Long)
   private object WeightedSample {
+    private object WeightedSampleOrdering extends Ordering[WeightedSample[_]] {
+      override def compare(x: WeightedSample[_], y: WeightedSample[_]): Int =
+        java.lang.Long.compare(y.id, x.id) // reverse order
+    }
+
     implicit def ordering[T]: Ordering[WeightedSample[T]] =
-      Ordering.by[WeightedSample[T], Long](_.id).reverse
+      WeightedSampleOrdering.asInstanceOf[Ordering[WeightedSample[T]]]
   }
 
   final private case class WeightedCombiner[T](