use noOp cache instead of null when instantiating typedSparkeySideInp…

…ut (#5469) Co-authored-by: Michel Davit <[email protected]> Co-authored-by: Michel Davit <[email protected]>
spotify · Sep 5, 2024 · 078519c · 078519c
1 parent ee28d27
commit 078519c
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/scio-extra/src/main/scala/com/spotify/scio/extra/sparkey/package.scala b/scio-extra/src/main/scala/com/spotify/scio/extra/sparkey/package.scala
@@ -152,7 +152,15 @@ package object sparkey extends SparkeyReaderInstances with SparkeyCoders {
       decoder: Array[Byte] => T,
       cache: Cache[String, T] = null
     ): SideInput[TypedSparkeyReader[T]] =
-      sparkeySideInput(basePath, reader => new TypedSparkeyReader[T](reader, decoder, cache))
+      sparkeySideInput(
+        basePath,
+        reader =>
+          new TypedSparkeyReader[T](
+            reader,
+            decoder,
+            Option(cache).getOrElse(Cache.noOp[String, T])
+          )
+      )
 
     /**
      * Create a SideInput of `CachedStringSparkeyReader` from a [[SparkeyUri]] base path, to be used