Add Proto BigDiffy example #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 69.76% 70.91% +1.15%
==========================================
Files 22 24 +2
Lines 959 1021 +62
Branches 117 125 +8
==========================================
+ Hits 669 724 +55
- Misses 290 297 +7
Continue to review full report at Codecov.
|
jbigred1
reviewed
Apr 23, 2018
| @@ -282,6 +282,22 @@ object BigDiffy extends Command { | |||
| r.setFields(mergeFields(x.getFields.asScala, y.getFields.asScala).asJava) | |||
| } | |||
|
|
|||
| def saveStats[T](bigDiffy: BigDiffy[T], output: String, withHeader: Boolean = false): Any = { | |||
There was a problem hiding this comment.
should this return Unit instead
jbigred1
reviewed
Apr 23, 2018
| args.list("unordered").toSet) | ||
| } catch { | ||
| case e: Throwable => | ||
| throw e |
There was a problem hiding this comment.
what's the point of doing this
jbigred1
reviewed
Apr 23, 2018
| @@ -27,6 +27,7 @@ import com.spotify.ratatool.avro.specific.{EnumField, ExampleRecord, NestedExamp | |||
| import com.spotify.ratatool.scalacheck._ | |||
| import org.apache.avro.util.Utf8 | |||
| import org.scalacheck.{Arbitrary, Gen} | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick workaround for #83 which has a bit of complexity due to ProtoBuf APIs.