Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OpenTelemetry Support #198

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Abhi347
Copy link
Member

@Abhi347 Abhi347 commented Sep 17, 2024

feat: Add OpenTelemetry Support
feat: Add Support for Tracing Propagation Headers

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 75.07082% with 88 lines in your changes missing coverage. Please review.

Project coverage is 76.62%. Comparing base (936d075) to head (92c9da5).

Files with missing lines Patch % Lines
...va/com/spotify/github/v3/clients/GitHubClient.java 74.82% 63 Missing and 7 partials ⚠️
...tify/github/tracing/opencensus/OpenCensusSpan.java 16.66% 5 Missing ⚠️
...ithub/tracing/opentelemetry/OpenTelemetrySpan.java 75.00% 5 Missing ⚠️
...in/java/com/spotify/github/tracing/BaseTracer.java 81.81% 2 Missing ⚠️
...n/java/com/spotify/github/tracing/TraceHelper.java 0.00% 2 Missing ⚠️
...hub/tracing/opentelemetry/OpenTelemetryTracer.java 90.00% 1 Missing and 1 partial ⚠️
...fy/github/tracing/opencensus/OpenCensusTracer.java 66.66% 0 Missing and 1 partial ⚠️
...java/com/spotify/github/v3/clients/NoopTracer.java 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
- Coverage     76.67%   76.62%   -0.06%     
- Complexity      328      342      +14     
============================================
  Files            44       48       +4     
  Lines          1089     1155      +66     
  Branches         44       47       +3     
============================================
+ Hits            835      885      +50     
- Misses          225      239      +14     
- Partials         29       31       +2     
Flag Coverage Δ
76.62% <75.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abhi347 Abhi347 force-pushed the feat/add-ot-support branch 2 times, most recently from cfd6d53 to d5b90e3 Compare September 17, 2024 15:36
feat: Add OpenTelemetry Support
feat: Add Support for Tracing Propagation Headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant