feat: add telemetry on resolve latency #158
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
commented
Nov 14, 2024
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| final class ConfidenceIntegrationTest { |
There was a problem hiding this comment.
We were missing good integration tests for resolving using the Confidence SDK standalone. This class was copied from the Provider tests and just massaged to fit the SDK APIs.
nicklasl
commented
Nov 14, 2024
| @@ -30,7 +30,8 @@ private static ConfidenceValue from(com.google.protobuf.Value value, FlagSchema | |||
| if (intVal != value.getNumberValue()) { | |||
| throw new ParseError( | |||
| String.format( | |||
| "%s %s should be an int, but it is a double/long", mismatchPrefix, value)); | |||
| "%s %s should be an int, but it is a double/long", | |||
| mismatchPrefix, value.getNumberValue())); | |||
There was a problem hiding this comment.
Using value.getNumberValue() here since value actually contained a line break which annoyed me when writing tests :)
nicklasl
commented
Nov 14, 2024
|
|
||
| public class TelemetryClientInterceptor implements ClientInterceptor { | ||
| public static final Metadata.Key<String> HEADER_KEY = | ||
| Metadata.Key.of("X-CONFIDENCE-TELEMETRY", Metadata.ASCII_STRING_MARSHALLER); |
There was a problem hiding this comment.
Add the header in binary instead and the header with -bin suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea with this PR is to add a header with information about how long each resolve took.
It's defining a proto message and encodes the telemetry data in this message as a Base64 string putting it to the
X-CONFIDENCE-TELEMETRY.