fix: event engine rewrite #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
reviewed
Apr 11, 2024
src/test/java/com/spotify/confidence/ConfidenceEventSenderIntegrationTest.java
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Apr 11, 2024
src/main/java/com/spotify/confidence/EventSenderEngineImpl.java
Outdated
Show resolved
Hide resolved
nicklasl
force-pushed
the
simpler-event-sender
branch
from
03658e7
to
2f568c7
Compare
src/main/java/com/spotify/confidence/EventSenderEngineImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/spotify/confidence/EventSenderEngineImpl.java
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Apr 11, 2024
src/main/java/com/spotify/confidence/EventSenderEngineImpl.java
Outdated
Show resolved
Hide resolved
vahidlazio
reviewed
Apr 12, 2024
| final boolean passedMaxFlushInterval = | ||
| !maxFlushInterval.isZero() | ||
| && Duration.between(latestFlushTime, Instant.now()).compareTo(maxFlushInterval) > 0; | ||
| if (events.size() == maxBatchSize || passedMaxFlushInterval) { |
There was a problem hiding this comment.
if I understand the park correctly, if the current event is null, we wait until the maxFlushInterval and then here we check if we are passed that time (which in this case will be true) and then we upload events. should we check here as well if events are not empty?
There was a problem hiding this comment.
ah never mind, i checked further and realised this check exists in the upload. however i like to be more explicit and have the check here. I prefer the check to be here since calling the function upload and then the upload decides it doesn't want to handle the empty events wouldn't be clear. but absolutely not blocking.
nicklasl
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.