-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.37.0: Polars conv #61
Merged
Merged
Changes from 73 commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
e37b56e
add polars dep, upgrade pyarrow min version to 8.0.0 and cfb package …
saiemgilani f493ca8
now using `requests` module with req options/parameters passed to `d…
saiemgilani e83fa07
added some timing/memory usage decorators for profiling
saiemgilani b42ced2
updates to add `return_as_pandas` parameters
saiemgilani b93274a
minor cfb package updates
saiemgilani b77cd8b
Function `espn_cfb_game_rosters()` added.
saiemgilani ecfb2ca
Update mbb package to use polars
saiemgilani c79a0a1
Function `espn_nba_game_rosters()` added
saiemgilani 3234bc0
Update mbb_loaders.py
saiemgilani 713e07a
Missing imports added
saiemgilani f5ad90d
simplifying the returns on the helper functions in the `mbb.espn_mbb_…
saiemgilani 738de33
Update nba package to use polars
saiemgilani 6b1b7dc
Documentation examples
saiemgilani 6e19ff6
Updated nfl package to use polars
saiemgilani b71f572
simplifying the returns on the helper functions in the `cfb.espn_cfb_…
saiemgilani c711d9e
Update nhl package to use polars
saiemgilani 2caee12
Update wbb to polars
saiemgilani 1c6d8c6
Function nfl.nfl_game_rosters() added
saiemgilani daf2c7c
Update nhl_pbp.py
saiemgilani 3d3aa23
update init files
saiemgilani 85cad44
error in game_seconds_remaining
saiemgilani a9bdba2
Function `wnba.wnba_game_rosters()` added.
saiemgilani 7dac003
Update wnba package to polars
saiemgilani 9042beb
Update test_pbp.py
saiemgilani 44d88d8
Update retrosheet.py
saiemgilani 5d0fe7d
update requests for mlb module and add to init
saiemgilani b75333b
Function `nhl.nhl_game_rosters()` added
saiemgilani b9e1ef0
Update test_pbp to account for polars conventions
saiemgilani eead682
minor nfl_pbp updates (WIP)
saiemgilani 96d45b7
Update CHANGELOG.md
saiemgilani 06e5b0e
update docs
saiemgilani 3eaf954
Update tests.yml
saiemgilani 5519b49
Update python-publish.yml
saiemgilani 8e6290d
tests
saiemgilani 22fd209
Update tests.yml
saiemgilani 6ee26ba
pl.Int64 changes per comment
saiemgilani 4729354
black/flake/isort formatting, minor documentation details
saiemgilani a98074f
black
saiemgilani 164afb1
ep_final_names/wp_final_names were not imported
saiemgilani f7783d0
flake things
saiemgilani 0a748af
Update .flake8
saiemgilani 2eede28
Update .flake8
saiemgilani 8f05885
Update pyproject.toml
saiemgilani 52fbbc1
Update wnba_loaders.py
saiemgilani 32ca8f5
return_as_pandas=False
saiemgilani 5302e8c
docs
saiemgilani 718ecab
mlb
saiemgilani 138e546
schedule function drops leaders key
saiemgilani 285f2e3
changelog
saiemgilani cb71e1a
Function `cfb.load_cfb_betting_lines()` added.
saiemgilani 8f2acb4
docs
saiemgilani 9e2c8ac
schedule
saiemgilani 1b1c254
messing around with schedule things... it's a working mess
saiemgilani 52cb72a
updating test names
saiemgilani 635e043
nfl_pbp blindly updated to match cfb_pbp
saiemgilani 4fe1399
Update .gitignore
saiemgilani 3651508
nfl_pbp was missing a few params
saiemgilani 5b21788
removing unused vars
saiemgilani 892ec65
updating schedule documentation per PR comments
saiemgilani 5171d27
adding tests/function renaming
saiemgilani 652f7bd
fixing timeouts and formatting per PR comments
saiemgilani c5d110a
remove mlb
saiemgilani 444b4c1
mlb submodule moved to archive
saiemgilani 1df7a7c
sidebars
saiemgilani 2ae31fb
add cache documentation to teams functions
saiemgilani 935073c
cast sequenceNumber to pl.Int32
saiemgilani 0a15b22
None case for formatted (column) regex extraction, punt block return …
saiemgilani e60fa67
slight modifications for no
saiemgilani bd54587
Update nfl_pbp.py
saiemgilani dd1e6c7
more filtering to stop pipeline if len(plays_df) == 0
saiemgilani aab7e94
updating default overUnders basketball sports
saiemgilani 89018c2
adding a to in case of early termination of run_processing_pipeline
saiemgilani e5b8ecd
adding a to in case of early termination of run_processing_pipeline
saiemgilani 1ef7a15
updating pickcenter methods to be a bit more robust
saiemgilani a2fcba0
add janitor functions to polars dataframe namespace
saiemgilani e0b110d
no_espn_data error added
saiemgilani 259ec39
configs updated to use fstrings
saiemgilani d1a0fa6
extract event parsing, janitor clean names
saiemgilani e45322d
add corrupt pbp check for completed games
saiemgilani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[flake8] | ||
max-line-length = 120 | ||
max-complexity = 18 | ||
select = B,C,E,F,W,T4,B9 | ||
extend-ignore = E203, E265, E266, E400, E501, E712, W503, B905, B907 | ||
enable-extensions = G | ||
import-order-style = google | ||
application-import-names = sportsdataverse,test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,7 @@ docs/node_modules | |
build | ||
dist | ||
*.ipynb | ||
.ipynb_checkpoints | ||
./.ipynb_checkpoints | ||
*/.ipynb_checkpoints | ||
*.egg-info |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,52 @@ | ||
# See https://pre-commit.com for more information | ||
# See https://pre-commit.com/hooks.html for more hooks | ||
repos: | ||
# - repo: local | ||
# hooks: | ||
# - id: update-docs | ||
# name: update-docs | ||
# entry: bash create_docs.sh | ||
# language: system | ||
# types: [python] | ||
# pass_filenames: false | ||
|
||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v4.0.1 | ||
hooks: | ||
- id: trailing-whitespace | ||
- id: trailing-whitespace | ||
- id: check-merge-conflict | ||
- id: check-ast | ||
- id: check-toml | ||
- id: check-json | ||
- id: check-xml | ||
- id: check-yaml | ||
- id: check-symlinks | ||
- id: check-vcs-permalinks | ||
- id: end-of-file-fixer | ||
- id: requirements-txt-fixer | ||
- id: check-added-large-files | ||
args: [--maxkb=10000] | ||
- id: debug-statements | ||
|
||
- repo: https://github.com/psf/black | ||
rev: '23.1.0' | ||
hooks: | ||
- id: black | ||
- repo: https://github.com/pycqa/isort | ||
rev: '5.12.0' | ||
hooks: | ||
- id: isort | ||
- repo: https://github.com/hadialqattan/pycln | ||
rev: 'v2.1.5' | ||
hooks: | ||
- id: pycln | ||
args: ['.', "--all"] | ||
# - repo: https://github.com/pycqa/flake8 | ||
# rev: '3.9.2' | ||
# hooks: | ||
# - id: flake8 | ||
# - repo: https://github.com/pycqa/pydocstyle | ||
# rev: '6.3.0' | ||
# hooks: | ||
# - id: pydocstyle | ||
# args: ['.', '--ignore=D100,D203,D405'] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for convenience there should probably be a way to set this globally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't honestly know how to do that outside of a config file? It's certainly worth looking into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you know of a way to do this that doesn't cause significant work, I'll do it but I'm about dunnn with this overhaul so don't expect this one to get resolved