Be more strict in parsing arguments in run_tests #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In run_tests, when iterating over argv in Spork::TestFramework::TestUnit.run_tests the arguments are matched against /-I(.)/ to check for include paths and against /-r(.)/ to check for required files.
The problem is that these regexes match anywhere in any argument, but should match only the start of the arguments as otherwise any appearance of the sequences "-I" and "-r" in an argument will match and result in misbehaviour.
For example when trying to run a test "/home/me/my-rails-project/test/unit/test_test.rb" the "-r" in "my-rails-project" will match and run_tests will require the file "ails-project/test/unit/test_test.rb".
This is fixed by anchoring both of the regexes to the beginning of the string.