Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more strict in parsing arguments in run_tests #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

panos--
Copy link

@panos-- panos-- commented Aug 2, 2012

In run_tests, when iterating over argv in Spork::TestFramework::TestUnit.run_tests the arguments are matched against /-I(.)/ to check for include paths and against /-r(.)/ to check for required files.

The problem is that these regexes match anywhere in any argument, but should match only the start of the arguments as otherwise any appearance of the sequences "-I" and "-r" in an argument will match and result in misbehaviour.

For example when trying to run a test "/home/me/my-rails-project/test/unit/test_test.rb" the "-r" in "my-rails-project" will match and run_tests will require the file "ails-project/test/unit/test_test.rb".

This is fixed by anchoring both of the regexes to the beginning of the string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant