Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --compare_against flag to release_notes action #311

Merged
merged 6 commits into from
Oct 21, 2024
Merged

add --compare_against flag to release_notes action #311

merged 6 commits into from
Oct 21, 2024

Conversation

patel-bhavin
Copy link
Contributor

@patel-bhavin patel-bhavin commented Oct 19, 2024 •
edited
Loading

adds a flag to release_notes action -- compare_against : so that we can mention another branch name to compare and create notes against. Tested locally and the generation of notes looked good!

@patel-bhavin patel-bhavin changed the title release_notes update add --compare_against flag to release_notes action Oct 19, 2024
pyth0n1c
pyth0n1c approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be future work where we place stricter requirements on what subset of arguments can be provided in terms of old_tag/new_tag and branch names, but this is acceptable for now.

@pyth0n1c pyth0n1c merged commit d4d7d9d into main Oct 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyth0n1c pyth0n1c pyth0n1c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patel-bhavin @pyth0n1c