Skip to content

Commit

Permalink
default to devleop
Browse files Browse the repository at this point in the history
  • Loading branch information
patel-bhavin committed Oct 21, 2024
1 parent d12a173 commit f7204a1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions contentctl/actions/release_notes.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,8 @@ def release_notes(self, config:release_notes) -> None:
raise ValueError(f"latest branch {config.latest_branch} does not exist in the repository. Make sure your branch name is correct")
if config.compare_against not in repo.branches:
raise ValueError(f"compare_against branch {config.compare_against} does not exist in the repository. Make sure your branch name is correct")
compare_against = config.compare_against
commit1 = repo.commit(config.latest_branch)
commit2 = repo.commit(compare_against)
commit2 = repo.commit(config.compare_against)
diff_index = commit2.diff(commit1)

modified_files:List[pathlib.Path] = []
Expand Down
2 changes: 1 addition & 1 deletion contentctl/objects/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ class release_notes(Config_Base):
new_tag:Optional[str] = Field(None, description="Name of the tag containing new content. If it is not supplied,"
" then it will be inferred as the newest tag at runtime.")
latest_branch:Optional[str] = Field(None, description="Branch name for which we are generating release notes for")
compare_against:Optional[str] = Field(None, description="Branch name for which we are comparing the files changes against")
compare_against:Optional[str] = Field(default="develop", description="Branch name for which we are comparing the files changes against")

def releaseNotesFilename(self, filename:str)->pathlib.Path:
#Assume that notes are written to dist/. This does not respect build_dir since that is
Expand Down

0 comments on commit f7204a1

Please sign in to comment.