Allow requiring use of a post-quantum-safe KEM #5601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlandau
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
azdagron
previously approved these changes
Nov 4, 2024
| import ( | ||
| "crypto/tls" | ||
|
|
||
| "github.com/hashicorp/go-hclog" |
There was a problem hiding this comment.
This package should leverage a logrus logger instead of hclog. The only code in the codebase that uses hclog is plugin code (due to tight coupling with hashicorp/go-plugin).
There was a problem hiding this comment.
We can leave this for now. If this feature becomes non-experimental at some point, we'll likely be passing this configuration to plugins via core configuration and can revisit this then.
|
Thanks for this, @hlandau. Would you mind merging in the latest main and fixing up the conflict? |
azdagron
previously approved these changes
Nov 6, 2024
Signed-off-by: Hugo Landau <[email protected]>
Signed-off-by: Hugo Landau <[email protected]>
Signed-off-by: Hugo Landau <[email protected]>
|
@azdagron Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an experimental
require_pq_kemboolean configuration option to the SPIRE agent and server which requires use of a post-quantum safe KEM (currently, the x25519Kyber768Draft00 KEM supported in Go 1.23).This supercedes https://github.com/spiffe/spire/pull/5371.and implements the changes discussed there.