Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes broken links generated on relative URLs #215

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Fixes broken links generated on relative URLs #215

Changes from 2 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
5f30bce
Fixes broken links generated on relative urls when importing external…
Apr 12, 2021
f10a384
Merge branch 'master' into fix-broken-links
Apr 19, 2021
35ea988
Removes outdated java-spiffe example
Apr 20, 2021
a05f665
Updates go-spiffe default branch
Apr 20, 2021
ff21e1c
Replace David Langhorst with Andres Gomez Coronel as codeowner
May 6, 2021
beed7a7
Fixes broken links
May 4, 2021
342a749
Changes to pull docs from latest spire release
Apr 5, 2021
94562c5
Pull latest release only once per build
Apr 5, 2021
068f14e
Removes extra sentence
Apr 5, 2021
1cec96e
Addresses PR comments
Apr 20, 2021
ef93dfa
Addresses comment
May 3, 2021
cc5eb0e
Fixes wrong spire github url
May 14, 2021
5a29928
Fix broken URLs discovered by new link checker
sanderson042 May 28, 2021
bccc464
Clarify status of new c-spiffe library
sanderson042 Jun 2, 2021
1b50a09
Adds broken links checks
Apr 22, 2021
1eb887f
Locks linkchecker version
Apr 27, 2021
81ca767
Fixes checkextern mode
Apr 28, 2021
744ac8a
Ignores letsencrypt's urls
Apr 28, 2021
68832ed
Adds missing newline
Apr 29, 2021
af0a97f
Disables anchor checking
May 3, 2021
31a2c48
Add clarification about serve commands
Jun 2, 2021
2028480
Addresses PR comments by @sanderson042
Jun 8, 2021
eb09d03
Add Rust library link to the libraries doc.
maxlambrecht Jun 28, 2021
008fb14
Add comment about Rust not official library.
maxlambrecht Jun 28, 2021
464ab43
Fix #227 - Add link to Plugin SDK in "Extend SPIRE" page
sanderson042 Sep 24, 2021
cd2e2ee
Fix SPIRE capitalization and make Key Manager spelling consistent
sanderson042 Sep 24, 2021
2b80387
Fixing a small fix on Node Resolver text.
glaucimar Oct 20, 2021
b11a960
Update links to spiffe master branch to main instead
mjlshen Jan 21, 2022
f54800e
Fixes broken links generated on relative urls when importing external…
Apr 12, 2021
a901fd1
merge conflicts
Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pull_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,14 +245,14 @@ def repl_links(m: Match[str]):
new_url = url
# this is an internal relative url
else:
if rel == "/":
rel_url = url
elif rel == "./" or rel == "":
rel_url = os.path.join(os.path.dirname(rel_path_to_source_file), url)
rel_url = os.path.normpath(
os.path.join(os.path.dirname(rel_path_to_source_file), rel, url)
)

new_url = "https://github.com/{}/{}/blob/master/{}".format(
repo_owner, repo_name, rel_url
)

# if this file has been already pulled in, we can use the new internal URL
# instead of pointing to the original github location
if new_url in internal_links:
Expand Down