Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump linter to 1.52.2 #127

Merged
merged 5 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ else
endif
go_path := PATH="$(go_bin_dir):$(PATH)"

golangci_lint_version = v1.51.1
golangci_lint_version = v1.52.2
golangci_lint_dir = $(build_dir)/golangci_lint/$(golangci_lint_version)
golangci_lint_bin = $(golangci_lint_dir)/golangci-lint
golangci_lint_cache = $(golangci_lint_dir)/cache
Expand Down
11 changes: 2 additions & 9 deletions pkg/sidecar/sidecar.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,7 @@ func (s *Sidecar) dumpBundles(svidResponse *workloadapi.X509Context) error {
return err
}

if err := writeCerts(svidBundleFile, bundles); err != nil {
return err
}

return nil
return writeCerts(svidBundleFile, bundles)
}

func (s *Sidecar) writeJSON(fileName string, certs map[string]interface{}) error {
Expand All @@ -251,11 +247,8 @@ func (s *Sidecar) writeJSON(fileName string, certs map[string]interface{}) error
}

jsonPath := path.Join(s.config.CertDir, fileName)
if err = os.WriteFile(jsonPath, file, os.ModePerm); err != nil {
return err
}

return nil
return os.WriteFile(jsonPath, file, os.ModePerm)
}

func (s *Sidecar) updateJWTBundle(jwkSet *jwtbundle.Set) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/sidecar/util_posix.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ func (s *Sidecar) SignalProcess() error {
return nil
}

func validateOSConfig(c *Config) error {
func validateOSConfig(_ *Config) error {
faisal-memon marked this conversation as resolved.
Show resolved Hide resolved
return nil
}
Loading