Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exitOnWait flag #126

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Add exitOnWait flag #126

merged 5 commits into from
Jan 16, 2024

Conversation

kfox1111
Copy link
Contributor

@kfox1111 kfox1111 commented Jan 6, 2024

This enables the exitOnWait behavior from the commandline so most users don't need to define two different config files.

This enables the exitOnWait behavior from the commandline so most
users don't need to define two different config files.

Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Copy link
Contributor Author

kfox1111 commented Jan 6, 2024

There should probably be a bigger conversation about having all config file options also be flags. But until then, this PR will enable a pretty good savings on configuration.

Signed-off-by: Kevin Fox <[email protected]>
Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we must provide more flags here... but this is a good example,
if we go for that approach, I think we may move the config parsing to another place, to simplify changing values from configs from flags...

pkg/sidecar/sidecar_test.go Show resolved Hide resolved
@MarcosDY MarcosDY merged commit a2f5caf into spiffe:main Jan 16, 2024
12 checks passed
@kfox1111 kfox1111 deleted the exit-when-ready-cli branch January 16, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants