Add support for federated mode #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfox1111
reviewed
Jan 3, 2024
MarcosDY
reviewed
Jan 10, 2024
MarcosDY
approved these changes
Jan 16, 2024
|
@edurra chabges looks good, but can you solve DCO? so we can merge, thanks!!! |
Signed-off-by: Eduardo <[email protected]>
Signed-off-by: Eduardo <[email protected]>
Signed-off-by: Eduardo <[email protected]>
Signed-off-by: Eduardo <[email protected]>
Signed-off-by: Eduardo <[email protected]>
Signed-off-by: Eduardo <[email protected]>
sure! done, let me know if I have to do anything else. |
|
@edurra Got some linter errors. Can you take a look? https://github.com/spiffe/spiffe-helper/actions/runs/7545693167/job/20541900458?pr=124 |
Signed-off-by: Eduardo <[email protected]>
done, I just tested locally and it should be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated on Issue 89 , SPIFFE Helper does not support federated mode, meaning that a trust bundle from a federated domain is not retrieved.
This pull request includes two configuration options to support fetching a federated domain trust bundle:
include_federated_domains: if true, it will include CA certificates from federated trust domains in the ca bundle.The committed code does the following:
include_federated_domainsparameter is true2.1. Fetch the bundle associated to the federated trust domains from the
svidResponseobject2.2. Store the append the bundles to the CA trust bundle