-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple JWT tokens to be configured (closes #108) #109
Conversation
Signed-off-by: Keegan Witt <[email protected]>
38cb421
to
9d4c4d6
Compare
@keeganwitt Thanks for the submission. Couple questions:
|
My intention was for it to look something like this (and maybe the way I've got it in my PR isn't quite right) "jwt_svids": [
{
"jwt_audience": "some-audience",
"jwt_svid_file_name": "some/path/some-audience.jwt"
}
]
This might be an acceptable approach. In our specific case, that would be acceptable. But my thinking was what if you required these JWTs to be in different Kubernetes volumes? There'd be no way to do this. So I thought it was better to choose an option that would offer more flexibility. |
I discovered #112 while working on this, which is probably a pre-requisite. |
Seems about right.
Good point. |
298a3a1
to
7aea7b1
Compare
Signed-off-by: Keegan Witt <[email protected]>
7aea7b1
to
4ca75de
Compare
@keeganwitt changes are looking good. Can you update the readme? |
Signed-off-by: Keegan Witt <[email protected]>
Oops. Yes. Done. |
Signed-off-by: Keegan Witt <[email protected]>
Co-authored-by: Marcos Yacob <[email protected]> Signed-off-by: Keegan Witt <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
Co-authored-by: Faisal Memon <[email protected]> Signed-off-by: Keegan Witt <[email protected]>
# Conflicts: # README.md
Co-authored-by: Faisal Memon <[email protected]> Signed-off-by: Keegan Witt <[email protected]>
Co-authored-by: Faisal Memon <[email protected]> Signed-off-by: Keegan Witt <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @keeganwitt changes look good to me. @MarcosDY is it ok with you?
No description provided.