Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Add arm64 support to Helm chart #74

Merged
merged 5 commits into from
Mar 1, 2023
Merged

Add arm64 support to Helm chart #74

merged 5 commits into from
Mar 1, 2023

Conversation

marcofranssen
Copy link
Contributor

@marcofranssen marcofranssen commented Mar 1, 2023 •
edited
Loading

  • Bump spire-server image to 1.6.0 (arm64 support)
  • Bump spire-agent image to 1.6.0 (arm64 support)
  • Bump spiffe-oidc-discovery-provider image to 1.6.0 (arm64 support)
  • Bump spiffe-csi-driver image to 0.2.3 (arm64 support)

See here a list of all my PRs that enabled the arm64 support in the different spire images.

wait-for-it initContainer

spiffe-csi-driver

spire

spire-controller-manager

This feels like a huge achievement.

@marcofranssen marcofranssen enabled auto-merge March 1, 2023 11:38
@kfox1111
Copy link
Contributor

kfox1111 commented Mar 1, 2023

In general this looks good to me. need to decide if this belongs in 1.0.

@faisal-memon
Copy link
Contributor

In general this looks good to me. need to decide if this belongs in 1.0.

I think arm64 support is important and we should have it in our 1.0 release.

@kfox1111
Copy link
Contributor

kfox1111 commented Mar 1, 2023

In general this looks good to me. need to decide if this belongs in 1.0.

I think arm64 support is important and we should have it in our 1.0 release.

I think its useful. But I don't think its any more or less useful then say nested spire. If we're going to prioritize features for 1.0 we need to be consistent.

@marcofranssen
Copy link
Contributor Author

marcofranssen commented Mar 1, 2023 •
edited
Loading

This definitely is more important then nested spire. It also is less impactful as it doesn't change the architecture of the chart. As said nested spire and federated spire where not part of the original 1.0 release plan. We will get there as well but this requires some more discussion and design.

@faisal-memon
Copy link
Contributor

This definitely is more important then nested spire. It also is less impactful as it doesn't change the architecture of the chart. As said nested spire and federated spire where not part of the original 1.0 release plan. We will get there as well but this requires some more discussion and design.

Agree

@kfox1111
Copy link
Contributor

kfox1111 commented Mar 1, 2023

This definitely is more important then nested spire. It also is less impactful as it doesn't change the architecture of the chart. As said nested spire and federated spire where not part of the original 1.0 release plan. We will get there as well but this requires some more discussion and design.

More important, to you. That is the sore spot. We're in this together. My pr's getting blocked because its not your priorities isn't a very good way to do things in the open source community.

I agree its less impactful on the merge, but I'd say its more important to get the api right for a v1 release, so in some ways nested spire's api is more important IMO.

kfox1111
kfox1111 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me all around.

@marcofranssen marcofranssen merged commit fe7cd73 into main Mar 1, 2023
@marcofranssen marcofranssen deleted the arm64-support branch March 2, 2023 07:49
@marcofranssen marcofranssen added this to the Initial release milestone Mar 2, 2023
marcofranssen added a commit that referenced this pull request Mar 7, 2023
@marcofranssen
Bump spire Helm Chart version from 0.3.0 to 0.4.0
0f98115 
* eb186ca Add values for server TTL configurables
* f123296 Add a flag to configure the Kubernetes NodeAttestor (#83)
* 0275569 Incorperate feedback
* a00c97b Incorperate feedback
* f93434a Make server service account allow list configurable
* f0b7f5b Make spire agent server address configurable
* cb627f0 Allow all subchart to conditionally disable (#90)
* 2e9510f Switch to non root nginx (#89)
* a901751 Fix Homepage URL
* 06c395f Fix sources in Chart.yaml (#85)
* d341c5a UpstreamAuthority cert-manager support (#82)
* a82ee69 Make sure all configmap changes rollout
* b7f8c86 Add extra initContainers, containers, volumes to agent and server
* 81ac89a Add k8s 1.26.0 (Kind) to the test matrix
* bb6abfc Merge pull request #76 from spiffe/dependabot/github_actions/sigstore/cosign-installer-3.0.1
* c0e5665 Bump cosign to v2.0.0
* d729a44 Bump sigstore/cosign-installer from 2.8.1 to 3.0.1
* fe7cd73 Merge pull request #74 from spiffe/arm64-support
* a3c04c0 Update supported versions
* 75480ed Bump spiffe-csi-driver image to 0.2.3 (arm64 support)
* 79889ff Bump spiffe-oidc-discovery-provider image to 1.6.0 (arm64 support)
* a632f76 Bump spire-agent image to 1.6.0 (arm64 support)
* b92e81d Bump spire-server image to 1.6.0 (arm64 support)
* fea2aa5 Fix sigstore/cosign-installer usage in release workflow
* fe93346 Use quote function instead of actual quotes
* 9480ab7 Add beta note to readme (#62)
* 4681498 Better spire-server entry commands (#59)

Signed-off-by: Marco Franssen <[email protected]>
marcofranssen added a commit that referenced this pull request Mar 7, 2023
@marcofranssen
Bump spire Helm Chart version from 0.3.0 to 0.4.0
a803139 
* eb186ca Add values for server TTL configurables
* f123296 Add a flag to configure the Kubernetes NodeAttestor (#83)
* 0275569 Incorperate feedback
* a00c97b Incorperate feedback
* f93434a Make server service account allow list configurable
* f0b7f5b Make spire agent server address configurable
* cb627f0 Allow all subchart to conditionally disable (#90)
* 2e9510f Switch to non root nginx (#89)
* a901751 Fix Homepage URL
* 06c395f Fix sources in Chart.yaml (#85)
* d341c5a UpstreamAuthority cert-manager support (#82)
* a82ee69 Make sure all configmap changes rollout
* b7f8c86 Add extra initContainers, containers, volumes to agent and server
* 81ac89a Add k8s 1.26.0 (Kind) to the test matrix
* bb6abfc Merge pull request #76 from spiffe/dependabot/github_actions/sigstore/cosign-installer-3.0.1
* c0e5665 Bump cosign to v2.0.0
* d729a44 Bump sigstore/cosign-installer from 2.8.1 to 3.0.1
* fe7cd73 Merge pull request #74 from spiffe/arm64-support
* a3c04c0 Update supported versions
* 75480ed Bump spiffe-csi-driver image to 0.2.3 (arm64 support)
* 79889ff Bump spiffe-oidc-discovery-provider image to 1.6.0 (arm64 support)
* a632f76 Bump spire-agent image to 1.6.0 (arm64 support)
* b92e81d Bump spire-server image to 1.6.0 (arm64 support)
* fea2aa5 Fix sigstore/cosign-installer usage in release workflow
* fe93346 Use quote function instead of actual quotes
* 9480ab7 Add beta note to readme (#62)
* 4681498 Better spire-server entry commands (#59)

Signed-off-by: Marco Franssen <[email protected]>
marcofranssen added a commit that referenced this pull request Mar 7, 2023
@marcofranssen
Bump spire Helm Chart version from 0.3.0 to 0.4.0
1f2df0f 
* eb186ca Add values for server TTL configurables
* f123296 Add a flag to configure the Kubernetes NodeAttestor (#83)
* 0275569 Incorperate feedback
* a00c97b Incorperate feedback
* f93434a Make server service account allow list configurable
* f0b7f5b Make spire agent server address configurable
* cb627f0 Allow all subchart to conditionally disable (#90)
* 2e9510f Switch to non root nginx (#89)
* a901751 Fix Homepage URL
* 06c395f Fix sources in Chart.yaml (#85)
* d341c5a UpstreamAuthority cert-manager support (#82)
* a82ee69 Make sure all configmap changes rollout
* b7f8c86 Add extra initContainers, containers, volumes to agent and server
* 81ac89a Add k8s 1.26.0 (Kind) to the test matrix
* bb6abfc Merge pull request #76 from spiffe/dependabot/github_actions/sigstore/cosign-installer-3.0.1
* c0e5665 Bump cosign to v2.0.0
* d729a44 Bump sigstore/cosign-installer from 2.8.1 to 3.0.1
* fe7cd73 Merge pull request #74 from spiffe/arm64-support
* a3c04c0 Update supported versions
* 75480ed Bump spiffe-csi-driver image to 0.2.3 (arm64 support)
* 79889ff Bump spiffe-oidc-discovery-provider image to 1.6.0 (arm64 support)
* a632f76 Bump spire-agent image to 1.6.0 (arm64 support)
* b92e81d Bump spire-server image to 1.6.0 (arm64 support)
* fea2aa5 Fix sigstore/cosign-installer usage in release workflow
* fe93346 Use quote function instead of actual quotes
* 9480ab7 Add beta note to readme (#62)
* 4681498 Better spire-server entry commands (#59)

Signed-off-by: Marco Franssen <[email protected]>
@marcofranssen marcofranssen mentioned this pull request Mar 7, 2023
Merged
marcofranssen added a commit that referenced this pull request Mar 8, 2023
@marcofranssen
Bump spire Helm Chart version from 0.3.0 to 0.4.0
d1cc77b 
* 7984bbd Add script to automate cutting a release
* eb186ca Add values for server TTL configurables
* f123296 Add a flag to configure the Kubernetes NodeAttestor (#83)
* 0275569 Incorperate feedback
* a00c97b Incorperate feedback
* f93434a Make server service account allow list configurable
* f0b7f5b Make spire agent server address configurable
* cb627f0 Allow all subchart to conditionally disable (#90)
* 2e9510f Switch to non root nginx (#89)
* a901751 Fix Homepage URL
* 06c395f Fix sources in Chart.yaml (#85)
* d341c5a UpstreamAuthority cert-manager support (#82)
* a82ee69 Make sure all configmap changes rollout
* b7f8c86 Add extra initContainers, containers, volumes to agent and server
* 81ac89a Add k8s 1.26.0 (Kind) to the test matrix
* bb6abfc Merge pull request #76 from spiffe/dependabot/github_actions/sigstore/cosign-installer-3.0.1
* c0e5665 Bump cosign to v2.0.0
* d729a44 Bump sigstore/cosign-installer from 2.8.1 to 3.0.1
* fe7cd73 Merge pull request #74 from spiffe/arm64-support
* a3c04c0 Update supported versions
* 75480ed Bump spiffe-csi-driver image to 0.2.3 (arm64 support)
* 79889ff Bump spiffe-oidc-discovery-provider image to 1.6.0 (arm64 support)
* a632f76 Bump spire-agent image to 1.6.0 (arm64 support)
* b92e81d Bump spire-server image to 1.6.0 (arm64 support)
* fea2aa5 Fix sigstore/cosign-installer usage in release workflow
* fe93346 Use quote function instead of actual quotes
* 9480ab7 Add beta note to readme (#62)
* 4681498 Better spire-server entry commands (#59)

Signed-off-by: Marco Franssen <[email protected]>
marcofranssen added a commit that referenced this pull request Mar 8, 2023
@marcofranssen
Bump spire Helm Chart version from 0.3.0 to 0.4.0
02ed202 
* 7984bbd Add script to automate cutting a release
* eb186ca Add values for server TTL configurables
* f123296 Add a flag to configure the Kubernetes NodeAttestor (#83)
* 0275569 Incorperate feedback
* a00c97b Incorperate feedback
* f93434a Make server service account allow list configurable
* f0b7f5b Make spire agent server address configurable
* cb627f0 Allow all subchart to conditionally disable (#90)
* 2e9510f Switch to non root nginx (#89)
* a901751 Fix Homepage URL
* 06c395f Fix sources in Chart.yaml (#85)
* d341c5a UpstreamAuthority cert-manager support (#82)
* a82ee69 Make sure all configmap changes rollout
* b7f8c86 Add extra initContainers, containers, volumes to agent and server
* 81ac89a Add k8s 1.26.0 (Kind) to the test matrix
* bb6abfc Merge pull request #76 from spiffe/dependabot/github_actions/sigstore/cosign-installer-3.0.1
* c0e5665 Bump cosign to v2.0.0
* d729a44 Bump sigstore/cosign-installer from 2.8.1 to 3.0.1
* fe7cd73 Merge pull request #74 from spiffe/arm64-support
* a3c04c0 Update supported versions
* 75480ed Bump spiffe-csi-driver image to 0.2.3 (arm64 support)
* 79889ff Bump spiffe-oidc-discovery-provider image to 1.6.0 (arm64 support)
* a632f76 Bump spire-agent image to 1.6.0 (arm64 support)
* b92e81d Bump spire-server image to 1.6.0 (arm64 support)
* fea2aa5 Fix sigstore/cosign-installer usage in release workflow
* fe93346 Use quote function instead of actual quotes
* 9480ab7 Add beta note to readme (#62)
* 4681498 Better spire-server entry commands (#59)

Signed-off-by: Marco Franssen <[email protected]>
kfox1111 pushed a commit that referenced this pull request Mar 9, 2023
@marcofranssen @kfox1111
Bump spire Helm Chart version from 0.3.0 to 0.4.0
3f5e52f 
* 7984bbd Add script to automate cutting a release
* eb186ca Add values for server TTL configurables
* f123296 Add a flag to configure the Kubernetes NodeAttestor (#83)
* 0275569 Incorperate feedback
* a00c97b Incorperate feedback
* f93434a Make server service account allow list configurable
* f0b7f5b Make spire agent server address configurable
* cb627f0 Allow all subchart to conditionally disable (#90)
* 2e9510f Switch to non root nginx (#89)
* a901751 Fix Homepage URL
* 06c395f Fix sources in Chart.yaml (#85)
* d341c5a UpstreamAuthority cert-manager support (#82)
* a82ee69 Make sure all configmap changes rollout
* b7f8c86 Add extra initContainers, containers, volumes to agent and server
* 81ac89a Add k8s 1.26.0 (Kind) to the test matrix
* bb6abfc Merge pull request #76 from spiffe/dependabot/github_actions/sigstore/cosign-installer-3.0.1
* c0e5665 Bump cosign to v2.0.0
* d729a44 Bump sigstore/cosign-installer from 2.8.1 to 3.0.1
* fe7cd73 Merge pull request #74 from spiffe/arm64-support
* a3c04c0 Update supported versions
* 75480ed Bump spiffe-csi-driver image to 0.2.3 (arm64 support)
* 79889ff Bump spiffe-oidc-discovery-provider image to 1.6.0 (arm64 support)
* a632f76 Bump spire-agent image to 1.6.0 (arm64 support)
* b92e81d Bump spire-server image to 1.6.0 (arm64 support)
* fea2aa5 Fix sigstore/cosign-installer usage in release workflow
* fe93346 Use quote function instead of actual quotes
* 9480ab7 Add beta note to readme (#62)
* 4681498 Better spire-server entry commands (#59)

Signed-off-by: Marco Franssen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faisal-memon faisal-memon faisal-memon left review comments

@kfox1111 kfox1111 kfox1111 approved these changes

@developer-guy developer-guy Awaiting requested review from developer-guy

@dennisgove dennisgove Awaiting requested review from dennisgove

@dfeldman dfeldman Awaiting requested review from dfeldman

@mrsabath mrsabath Awaiting requested review from mrsabath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.x
Development

Successfully merging this pull request may close these issues.
3 participants
@marcofranssen @kfox1111 @faisal-memon