Apply suggestions from code review

Co-authored-by: Faisal Memon <[email protected]>
Signed-off-by: kfox1111 <[email protected]>

charts/spiffe-step-ssh/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v2
 name: spiffe-step-ssh
-description: sshd signed host certificates using SPIFFE for trust and step ca
+description: sshd signed host certificates using SPIFFE for trust and step CA
 
 # A chart can be either an 'application' or a 'library' chart.
 #

charts/spiffe-step-ssh/templates/ssh-certificate-issuer-password-secret.yaml

@@ -6,4 +6,3 @@ metadata:
     {{- include "spiffe-step-ssh.labels" . | nindent 4 }}
 data:
   password: {{ .Values.caPassword | b64enc }}
-

charts/spiffe-step-ssh/templates/step-ca-password-secret.yaml

@@ -6,4 +6,3 @@ metadata:
     {{- include "spiffe-step-ssh.labels" . | nindent 4 }}
 data:
   password: {{ .Values.caPassword | b64enc }}
-

charts/spiffe-step-ssh/templates/step-config.yaml

@@ -30,4 +30,3 @@ data:
 {{- end }}
   "ssh_x5c.tpl": |
     {{- .Files.Get "files/ssh_x5c.tpl" | replace "@TRUST_DOMAIN@" .Values.trustDomain | replace "@PREFIX@" .Values.prefix | nindent 4}}
-

tests/integration/spiffe-step-ssh/run-tests.sh

@@ -103,7 +103,6 @@ kubectl get configmap -n kube-system coredns -o yaml | grep test.production.othe
 kubectl rollout restart -n kube-system deployment/coredns
 kubectl rollout status -n kube-system -w --timeout=1m deploy/coredns
 
-#helm upgrade --install --create-namespace -n spire-system spire-crds charts/spire-crds
 helm upgrade --install --create-namespace --namespace spire-mgmt --values "${COMMON_TEST_YOUR_VALUES},${SCRIPTPATH}/root-values.yaml" \
   --wait spire charts/spire-nested \
   --set "global.spire.namespaces.create=true" \
@@ -119,8 +118,6 @@ if [[ "${ENTRIES}" == "Found 0 entries" ]]; then
   exit 1
 fi
 
-#helm test --namespace spire-mgmt spire
-
 kubectl get ingress -n spire-server
 
 echo "${IP} spire-server.production.other spiffe-step-ssh.production.other spiffe-step-ssh-fetchca.production.other" | sudo bash -c 'cat >> /etc/hosts'