Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry in func UpdateEgressGateway #662

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Conversation

bzsuni
Copy link
Collaborator

@bzsuni bzsuni commented Aug 1, 2023

fix resourceVersion modified when update EgressGateway #661

@bzsuni bzsuni added the release/none should not recoded in new release label Aug 1, 2023
@bzsuni bzsuni force-pushed the bz/e2e/UpdateEgressGateway branch from d2ece79 to 896a551 Compare August 1, 2023 10:52
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #662 (58ae14a) into main (3324215) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #662   +/-   ##
=======================================
  Coverage   10.45%   10.45%           
=======================================
  Files          19       19           
  Lines        3864     3864           
=======================================
  Hits          404      404           
  Misses       3384     3384           
  Partials       76       76           
Flag Coverage Δ
unittests 10.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

lou-lan
lou-lan previously approved these changes Aug 1, 2023
@weizhoublue
Copy link
Collaborator

weizhoublue commented Aug 2, 2023

有这么多用例在并发操作 egressGateway
这个 update 只是简单的 尝试 3 此,我看 并发的用例也不只 3 个,失败起来,3 次重试都不够
并且,这个 update 也不区分 是否 resourceviesion 是否 冲突 等 能够容忍的错误,万一有其他错误,岂不 被忽略了

应该要有一个更加聪明的写法,否则还会出现

@bzsuni bzsuni force-pushed the bz/e2e/UpdateEgressGateway branch from c8b8383 to 7b36949 Compare August 2, 2023 06:55
@weizhoublue weizhoublue merged commit d40c701 into main Aug 4, 2023
26 checks passed
@weizhoublue weizhoublue deleted the bz/e2e/UpdateEgressGateway branch August 4, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/none should not recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants