Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add sigterm signal #1508

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: add sigterm signal #1508

merged 1 commit into from
Oct 31, 2024

Conversation

rfyiamcool
Copy link
Contributor

desc

when k8s deletes a pod, it sends a sigterm signal.

@lou-lan lou-lan added release/none should not recoded in new release enhancement New feature or request and removed release/none should not recoded in new release labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (81907e9) to head (9965b42).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
- Coverage   81.74%   81.63%   -0.11%     
==========================================
  Files          19       19              
  Lines        2783     2783              
==========================================
- Hits         2275     2272       -3     
- Misses        397      399       +2     
- Partials      111      112       +1     
Flag Coverage Δ
unittests 81.63% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@lou-lan
Copy link
Collaborator

lou-lan commented Oct 28, 2024

Hi, thanks your contribution, there has DCO action checks.

https://github.com/spidernet-io/egressgateway/pull/1508/checks?check_run_id=31877831251

Signed-off-by: rfyiamcool <[email protected]>
@rfyiamcool
Copy link
Contributor Author

Hi, thanks your contribution, there has DCO action checks.

https://github.com/spidernet-io/egressgateway/pull/1508/checks?check_run_id=31877831251

done

@lou-lan
Copy link
Collaborator

lou-lan commented Oct 31, 2024

@weizhoublue cc

@weizhoublue weizhoublue merged commit ffff9c9 into spidernet-io:main Oct 31, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release/none should not recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants