Fix #160

spicywebau · Feb 17, 2021 · 0b77296 · 0b77296
1 parent 42ee225
commit 0b77296
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@
 ### Changed
 - The embedded asset caching added in Embedded Assets 2.3.0 now uses the Craft data cache, rather than manual saving of files within `storage/runtime/assets/embeddedassets` (thanks @johndwells)
 
+### Fixed
+- Fixed a potential error when trying to get the `EmbeddedAsset` model of an asset that wasn't an embedded asset
+
 ## 2.4.5 - 2020-12-29
 
 ### Changed

diff --git a/src/Service.php b/src/Service.php
@@ -645,7 +645,13 @@ static function() use($asset) {
 			},
 			0);
 
-        return Json::decodeIfJson($contents);
+        try {
+            $contents = Json::decode($contents);
+        } catch (\Throwable $e) {
+            throw new Exception('Tried to get the contents of a non-embedded asset');
+        }
+
+        return $contents;
     }
 
     /**