Make the first party extensions optional, add [extensions] extra #11747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
force-pushed
the
sphinxcontrib-optional
branch
from
347271f to
c43c379
Compare
hroncok
commented
Nov 6, 2023
|
I have identified 5 Fedora packages that are impacted by this change. Most of them explicitly build the docs in some of the removed formats and are fixed by declaring a dependency on the particular sphinxcontrib package. One of them was a bit more interesting, as the tests only (accidentally) succeeded with Long story short, we would like to have this change in Fedora. Please let me know if we should carry this downstream-only or if you are eventually interested as well. |
hroncok
force-pushed
the
sphinxcontrib-optional
branch
3 times, most recently
from
91ed8f5 to
44e34be
Compare
|
The flake8 CI fails in a file I have not changed. I proposed a fix in #11748 |
hroncok
force-pushed
the
sphinxcontrib-optional
branch
from
44e34be to
a8371a9
Compare
hroncok
changed the title
|
This would be too painful a change in terms of deprecations at the moment, so I've closed this PR. A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to make all the sphinxcontrib requirements optional.
Feature or Bugfix
Purpose
We package sphinx in Fedora Linux and we don't really have a strong reason to pull in packages like applehelp there.
I decided to see if we could get rid of them.
Detail
Note that this is a very early draft. I am yet to test this in Fedora and see if this approach is feasible.It works for us.If it is, this obviously requires some documentation changes and possible deprecations. I am however unable to drive that forward right now. I would be interested to hear from the Sphinx maintainers whether this approach makes sense or not at all.
Relates
Sphinxandsphinxcontrib-*#11567